Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not early return for validated task in synchronous mode #547

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Oct 30, 2024

Describe your changes and provide context

Early returning without re-execution may leave invalid state

Testing performed to validate your change

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (851b25b) to head (c643b52).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   54.89%   54.89%   -0.01%     
==========================================
  Files         631      631              
  Lines       54955    54954       -1     
==========================================
- Hits        30167    30165       -2     
- Misses      22630    22631       +1     
  Partials     2158     2158              
Files with missing lines Coverage Δ
tasks/scheduler.go 90.81% <100.00%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

@philipsu522 philipsu522 merged commit 02f1c2f into main Oct 30, 2024
15 checks passed
@philipsu522 philipsu522 deleted the occ-no-skip branch October 30, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants