New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H5: three refactoring changes #12

Open

jlie1803 wants to merge 3 commits into seis-635-spring2020:master from jlie1803:master

jlie1803 commented May 4, 2020 •

edited

Loading

1. change constant to a variable
Change the length of playNames from a fixed number 20 to a variable and assign int 20 to it

2. hide delegate
Decoupling by changing getDie1().getLastRoll() to one method and move it to Dice class

3. extract method
Extract statements in if(skunkDice.getLastRoll()==2) into a method twoSkunks()

jlie1803 added 3 commits

May 4, 2020 12:06


          refactoring 1: change constant to a variable

0c4b8f0


          refactoring 2: hide delegate

2192f35


          refactoring 3: extract method

c9c4159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet