Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H-5 Refactoring #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

H-5 Refactoring #4

wants to merge 1 commit into from

Conversation

kalebolson
Copy link

My primary focus with this Refactoring is to make the run() method shorter and easier to comprehend:

  • Extracted methods setNumPlayers() and setPlayerNames()
  • Extracted methods turn() and lastTurn() which contain everything that goes into one player's individual turn
  • Moved gameNotOver method to be declared outside the run() method so other methods can access it more easily
  • Extracted getWinner() method to return the index of the winner at the end

@kalebolson
Refactoring run()
308d4d1 
My primary focus with this Refactoring is to make the run() method shorter and easier to comprehend:
* Extracted methods setNumPlayers() and setPlayerNames()
* Extracted methods turn() and lastTurn() which contain everything that goes into one player's individual turn
* Moved gameNotOver method to be declared outside the run() method so other methods can access it more easily
* Extracted getWinner() method to return the index of the winner at the end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kalebolson