[feat](binlog) Add Support recover binlog #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vallishp
force-pushed
the
recover_info_binlog
branch
2 times, most recently
from
415b68a to
2a6113a
Compare
Vallishp
force-pushed
the
recover_info_binlog
branch
4 times, most recently
from
3817091 to
844d57f
Compare
Vallishp
force-pushed
the
recover_info_binlog
branch
from
844d57f to
9891339
Compare
w41ter
requested changes
Dec 9, 2024
pkg/ccr/record/recover_info.go
Outdated
Comment on lines
32
to
33
| /* need check for db level not supported. | ||
| */ |
There was a problem hiding this comment.
Please add the above check, and also check if the table name and partition name exist.
pkg/ccr/job.go
Outdated
| return nil | ||
| } | ||
|
|
||
| if recoverInfo.PartitionName == "" { |
There was a problem hiding this comment.
Consider adding a helper function IsRecoverPartition() bool { return record.PartitionId == -1 }, and change below line to:
Suggested change
| if recoverInfo.PartitionName == "" { | |
| if recoverInfo.IsRecoverPartition() { |
Vallishp
force-pushed
the
recover_info_binlog
branch
from
9891339 to
131983c
Compare
w41ter
approved these changes
Dec 11, 2024
w41ter
pushed a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support recover table, recover partition
related PR: apache/doris#44818
Currently the recover flow, we will be do partial sync,
to can not gurantee the data present in the recycle bin of target.
Testcases run and passed.
DbSync
--- recover table
--- recover table as new table.
-- recover partition
-- recover partition as new partition name.
TableSync
-- recover partition
-- recover partition as new partition name.