Understand (and discard) SGR subparameters #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we do the math as we find each digit, rather than at the end after we have collected each digit. It's possible this is faster than extending a str and doing an `int(...)` conversion at the end (I haven't profiled it), but that's not why I made this change. I made this change to support an upcoming change to support SGR parameter "context", which is when a SGR CSI parameter is actually a list of integers: <selectel#178>. It's nicer to be able to collect the integers as we go, rather than having to process them all at the end.
This fixes selectel#178. Before, we assumed that CSI parameters are only integers. However, that caused us to barf in weird ways when presented with CSI parameters that contain `:`-delimited subparameters. This update to the parsing code causes us to parse those subparameters, and then immediately discard them. That may seem kind of weird, but I'm laying the groundwork for a followup change to the SGR handling code to actually be aware of subparameters (selectel#179). I just didn't want to muddy this diff with that change as well.
|
@superbobry, do you have any time to take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes #178. pyte now understands
:-delimited subparameters, but doesn't actually do anything with them (which is better than the previous behavior, where they'd get spewed to the screen buffer.I've split the work here into 2 separate commits, each with some explanation in the commit message, I recommend reading them independently.
I've also laid the groundwork for actually using these subparameters, which I'm tracking in #179