Selectize doesn't preserve title attribute #1200 #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selectize#1200 Update the code so that it preserves option title attribute. This is implement by adding a constant for extracting the value from the title attribute from the DOM option object. This is passed along with the rest of the extracted option information to the render function and then if it was present it is added to the HTML.
|
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1200
Update the code so that it preserves option title attribute.
This is implement by adding a constant for extracting the value from the title attribute from the DOM option object. This is passed along with the rest of the extracted option information to the render function and then if it was present it is added to the HTML.
This code changes are againset the tag 0.15.2 which is used by the website, hence it will not merge.