Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit if either of the two values doesn't exist or empty #101

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

PMohanJ
Copy link
Member

@PMohanJ PMohanJ commented Oct 2, 2023

A small fix at the if condition. As we need both values, turn_host and turn_port, we want the negation (not) to be applied to entire expression rather than just for the first variable followed by 'not' keyword.

Copy link
Member

@ehfd ehfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@ehfd ehfd merged commit f66f9e0 into selkies-project:main Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants