Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SMS docs to include GitLab #1788

Merged
merged 20 commits into from
Nov 12, 2024
Merged

Conversation

khorne3
Copy link
Collaborator

@khorne3 khorne3 commented Oct 16, 2024

Changes:

  • Updated the quickstart
  • Updated the information in Semgrep Managed Scanning, including splitting out GitHub- and GitLab-specific information into their own pages.

Previews:


Please ensure

  • A subject matter expert (SME) reviews the content
  • A technical writer reviews the content or PR
  • This change has no security implications or else you have pinged the security team
  • Redirects are added if the PR changes page URLs
  • If you have changed any header tag links (doc/#this-kind-of-anchor), update all instances of that link

Copy link

netlify bot commented Oct 16, 2024

Don't forget to add /docs at the end of the deploy preview site URL!

Name Link
🔨 Latest commit 3125f6e
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/672a8a4d69033d000812d5ad
😎 Deploy Preview https://deploy-preview-1788--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khorne3 khorne3 marked this pull request as ready for review October 16, 2024 15:19
@khorne3 khorne3 changed the title Update SMS docs to include GitLab update SMS docs to include GitLab Oct 16, 2024
Copy link
Collaborator

@s-santillan s-santillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff only, thank you for piecing out all the information!

Copy link

@Zhou-Duo Zhou-Duo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you katie 🎉!! these changes are very comprehensive! I've left some comments, but could you hold off on further work for now as the team's currently discussing whether we should release this private beta doc or keep it internal until the public beta (which we expect to launch in two weeks). I'll get back to you asap by EOD, in the worst case, we'll just frame it as 'public beta' and release it two weeks later. sorry for any inconvenience this may cause T T

docs/deployment/managed-scanning/overview.md Outdated Show resolved Hide resolved
docs/deployment/managed-scanning/gitlab.md Show resolved Hide resolved
@khorne3 khorne3 changed the title update SMS docs to include GitLab [HOLD] update SMS docs to include GitLab Oct 18, 2024
@khorne3 khorne3 changed the title [HOLD] update SMS docs to include GitLab update SMS docs to include GitLab Nov 11, 2024
@khorne3 khorne3 merged commit 8aea4e0 into main Nov 12, 2024
7 checks passed
@khorne3 khorne3 deleted the katiehorne/tec-191-update-sms-docs branch November 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants