Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update terms #1842

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

s-santillan
Copy link
Collaborator

@s-santillan s-santillan commented Nov 12, 2024

Thanks for improving Semgrep Docs 😀

Please ensure

  • A subject matter expert (SME) reviews the content
  • A technical writer reviews the content or PR

I checked the screenshots and they look for now to be up-to-date.

Copy link

netlify bot commented Nov 12, 2024

Don't forget to add /docs at the end of the deploy preview site URL!

Name Link
🔨 Latest commit a1295c2
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/673653a12e24f6000987ca25
😎 Deploy Preview https://deploy-preview-1842--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@s-santillan s-santillan requested review from khorne3 and zdhickman and removed request for khorne3 November 14, 2024 11:11
Copy link
Collaborator

@khorne3 khorne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nits, but otherwise looks good. Thank you!

docs/semgrep-appsec-platform/dashboard.md Outdated Show resolved Hide resolved
docs/semgrep-appsec-platform/dashboard.md Outdated Show resolved Hide resolved
docs/semgrep-appsec-platform/dashboard.md Outdated Show resolved Hide resolved
src/components/concept/_time-period-filters.md Outdated Show resolved Hide resolved
@s-santillan s-santillan added the hold Do not merge this PR label Nov 14, 2024
@zdhickman
Copy link
Contributor

Heads up that we're intending on changing the copy of this button - I can send you new screenshots when it's ready. It'll read more like a sentence e.g. Triaged last day instead of Last triaged (Last day)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Do not merge this PR
Development

Successfully merging this pull request may close these issues.

3 participants