feat: allow call suffixes #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonspark
requested review from
a team,
aryx and
SophiaSR
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR allows call suffixes to appear in assignment expressions, such as
Note that allowing call suffixes with type arguments (which look like
foo<T>(4)) caused tests to fail, because of a known ambiguity between type arguments and comparison operations. To ensure this did not happen, I created a new nonterminal which is just call suffixes without type arguments, and only allowed those. For the ones with type arguments, we will need a more sophisticated solution.Test plan:
make test