Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #57 #58

Closed
wants to merge 1 commit into from
Closed

closes #57 #58

wants to merge 1 commit into from

Conversation

cglewis
Copy link

@cglewis cglewis commented Oct 30, 2017

Fixes #57

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • N/A I have added necessary documentation about the functionality in the appropriate .md file
  • N/A I have added in line documentation to the code I modified

Short description of what this PR does:

  • adds codecov for travis tests

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@cglewis
Copy link
Author

cglewis commented Oct 31, 2017

not sure why it can't find a report to send to codecov... any ideas?

@mbernier
Copy link
Contributor

mbernier commented Nov 2, 2017

@cglewis It might be that I need to set something up - we are really far behind, but I will get to this as soon as I can!

@thinkingserious
Copy link
Contributor

@cglewis

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CodeCov support to .travis.yml
3 participants