Ignore errors when deciding whether to handle a file in global-eclim-… #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode. Otherwise a bad Eclipse state can cause an Emacs session to get very unpleasant. I'm not sure exactly what the mechanism is, but basic stuff like find-file, switch-buffer and *the M-x prompt* (of all things) stop working with the Eclipse error. To reproduce, define eclim--project-dir to (error something), then open a managed Java file not already open. Have the real eclim--project-dir ready; fortunately, eval-expression still works. The user can run eclim-mode manually if they want to investigate the error, or try to do anything that needs project-dir. I think even printing a message would still be too unpleasant in that state, hence ignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mode.
(While you're looking at my other stuff, ran into this problem recently)
Otherwise a bad Eclipse state can cause an Emacs session to get very
unpleasant. I'm not sure exactly what the mechanism is, but basic stuff
like find-file, switch-buffer and the M-x prompt (of all things) stop
working with the Eclipse error.
To reproduce, define eclim--project-dir to (error something), then open a
managed Java file not already open. Have the real eclim--project-dir ready;
fortunately, eval-expression still works.
The user can run eclim-mode manually if they want to investigate the error,
or try to do anything that needs project-dir. I think even printing a
message would still be too unpleasant in that state, hence ignore.