Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logger for debugging purposes #887

Merged
merged 4 commits into from
Aug 12, 2024
Merged

chore: add logger for debugging purposes #887

merged 4 commits into from
Aug 12, 2024

Conversation

mpfeil
Copy link
Member

@mpfeil mpfeil commented Aug 9, 2024

Description

This PR introduces different kind of logger. Right now the API has one logger and its the default one provided by restify and uses pino under the hode.

Motivation and Context

This hat a motivational background in debugging purposes and support requests. Right now it is only possible to see some basic information in requests coming in and sometimes it is quite hard to identify the issue.
The introduced debugLogger extends the log message by including the request body. It should only be used in support cases.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (update dependencies or documentation)

Checklist:

  • My code has been linted using yarn run lint.
  • My code does not break the tests (yarn run test)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@mpfeil mpfeil changed the title update pinojs chore: add logger for debugging purposes Aug 12, 2024
@mpfeil mpfeil self-assigned this Aug 12, 2024
@mpfeil mpfeil merged commit f9dc662 into master Aug 12, 2024
5 checks passed
@mpfeil mpfeil deleted the chore/logging branch August 12, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant