[FEATURE] Add http_Client as config (#31)

sensiolabs · Apr 16, 2024 · 71a9a43 · 71a9a43
1 parent 2fe18f7
commit 71a9a43
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 3 deletions.
diff --git a/config/services.php b/config/services.php
@@ -24,7 +24,7 @@
     $services->set('sensiolabs_gotenberg.client', GotenbergClient::class)
         ->args([
             abstract_arg('base_uri to gotenberg API'),
-            service(HttpClientInterface::class),
+            service('sensiolabs_gotenberg.http_client'),
         ])
         ->alias(GotenbergClientInterface::class, 'sensiolabs_gotenberg.client');
 

diff --git a/docs/configuration.rst b/docs/configuration.rst
@@ -10,6 +10,7 @@ The default configuration for the bundle looks like :
     sensiolabs_gotenberg:
         base_uri: 'http://localhost:3000'
         base_directory: '%kernel.project_dir%'
+        http_client: null # Defaults to 'http_client'
         default_options:
             html:
                 paper_width: null                   # 8.5

diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -8,6 +8,7 @@
 use Symfony\Component\Config\Definition\Builder\NodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
+use Symfony\Contracts\HttpClient\HttpClientInterface;
 
 class Configuration implements ConfigurationInterface
 {
@@ -26,8 +27,12 @@ public function getConfigTreeBuilder(): TreeBuilder
                     ->info('Base directory will be used for assets, files, markdown')
                     ->defaultValue('%kernel.project_dir%')
                 ->end()
+                ->scalarNode('http_client')
+                    ->info('HTTP Client reference to use. Defaults to "http_client".')
+                    ->defaultValue('http_client')
+                ->end()
                 ->arrayNode('default_options')
-                ->addDefaultsIfNotSet()
+                    ->addDefaultsIfNotSet()
                     ->append($this->addHtmlNode())
                     ->append($this->addUrlNode())
                     ->append($this->addMarkdownNode())

diff --git a/src/DependencyInjection/SensiolabsGotenbergExtension.php b/src/DependencyInjection/SensiolabsGotenbergExtension.php
@@ -4,6 +4,7 @@
 
 use Sensiolabs\GotenbergBundle\Builder\PdfBuilderInterface;
 use Symfony\Component\Config\FileLocator;
+use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
@@ -17,13 +18,15 @@ public function load(array $configs, ContainerBuilder $container): void
 
         $configuration = new Configuration();
 
-        /** @var array{base_uri: string, base_directory: string, default_options: array{html: array<string, mixed>, url: array<string, mixed>, markdown: array<string, mixed>, office: array<string, mixed>}} $config */
+        /** @var array{base_uri: string, http_client: string|null, base_directory: string, default_options: array{html: array<string, mixed>, url: array<string, mixed>, markdown: array<string, mixed>, office: array<string, mixed>}} $config */
         $config = $this->processConfiguration($configuration, $configs);
 
         $container->registerForAutoconfiguration(PdfBuilderInterface::class)
             ->addTag('sensiolabs_gotenberg.builder')
         ;
 
+        $container->setAlias('sensiolabs_gotenberg.http_client', new Alias($config['http_client'] ?? 'http_client', false));
+
         $definition = $container->getDefinition('sensiolabs_gotenberg.client');
         $definition->replaceArgument(0, $config['base_uri']);
 

diff --git a/tests/DependencyInjection/ConfigurationTest.php b/tests/DependencyInjection/ConfigurationTest.php
@@ -115,6 +115,7 @@ private static function getBundleDefaultConfig(): array
         return [
             'base_uri' => 'http://localhost:3000',
             'base_directory' => '%kernel.project_dir%',
+            'http_client' => 'http_client',
             'default_options' => [
                 'html' => [
                     'paper_width' => null,