Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --inode-mode option #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

boagg
Copy link
Contributor

@boagg boagg commented Apr 16, 2021

Signed-off-by: Steven Agbo [email protected]

Signed-off-by: Steven Agbo <[email protected]>
@jspaleta
Copy link
Contributor

Hey,
I'm not opposed to inode checking as an option, not sure about -j for the short option.. maybe its best not to give this a short option. This is going to need to be refactored a bit due to other PRs being merged in, so probably not merging this in this week.

@jspaleta
Copy link
Contributor

Hey,
Thinking a little more about this.. I think the inode centric functionality might be best as a separate command. The descriptive help text for some of the advanced options is probably going to be really confusing if they have to serve both inode and disk size.
It's not a lot of trouble to have separate commands, we can even ship multiple checks in the same asset as part of this repository.

I have to think about it a little bit more to be sure what the correct approach is long term.

@jspaleta
Copy link
Contributor

I'm gonna try to refactor this and get it merged after the magic option gets merged in.

@jspaleta jspaleta self-assigned this Jun 25, 2022
@pearsondavid
Copy link

@jspaleta Any update on this please? Being able to monitor inodes would have been extremely useful of late for me.

@pearsondavid
Copy link

@jspaleta Any update on this please?

@pearsondavid
Copy link

Adding my support for PR to be merged, been running this version in my local env without an issue for the last few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants