Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverside cookbooks should be suggested but not required #617

Closed

Conversation

smcavallo
Copy link
Contributor

Signed-off-by: S.Cavallo [email protected]
Addresses #616

Description

since this cookbook gets applied to both sensu server components (server + api + rabbitmq + redis) and sensu clients, the cookbooks which the server components require should be opted into.

Motivation and Context

allows consumers to opt-in for rabbitmq + redis cookbooks. opting in means that they'll be required to maintain these cookbooks as part of their chef implementation.

How Has This Been Tested?

normal testing as part of the PR process

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [X ] Breaking change (fix or feature that would cause existing functionality to change)

This is a breaking change. Since the default is now opt-out, consumers would need to implement the dependency requirements in their wrapper cookbooks.

Checklist:

  • [ X] My change requires a change to the documentation.
  • [X ] I have updated the documentation accordingly.
  • [ ]X I have read the CONTRIBUTING document.

Copy link
Contributor

@tas50 tas50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly recommend not doing this as suggests does nothing on the client side of depsolving. If you want to make something not actually a dep you should just remove it and note that you need it in the readme (which is also bad so don't do that)

@smcavallo
Copy link
Contributor Author

@tas50 - agreed - closing

@smcavallo smcavallo closed this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants