Allow disabling Uchiwa authentication #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s possible to disable authentication using this cookbook
majormoses
reviewed
Aug 6, 2017
majormoses
suggested changes
Aug 6, 2017
| @@ -21,7 +21,7 @@ | |||
| # Generate config file | |||
| settings = {} | |||
| node['uchiwa']['settings'].each do |k, v| | |||
| settings[k] = v | |||
| settings[k] = v unless v.nil? | |||
There was a problem hiding this comment.
This makes it possible to not specify required config, I'd opt to a check on k and look for the specific ones (username,password, etc) to allow being nil and then check those for nil and warn on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To disable authentication in Uchiwa you simply remove the user and pass keys in the Uchiwa configuration. This change prevents null set node['uchiwa']['settings'] attributes from being included in /etc/sensu/uchiwa.json. Therefore, to disable authentication simply set the user and pass Chef attributes to nil.