Deprecate the deprecator #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update actions and gitlab CI * update project path * use trigger API to build internal docker instead * test trigger on branch push * fix github action * test why trigger workflow not starting * fix branch name * remove step in trigger job * remove test branch * move mirror to a separate workflow, update pipeline running rules * Revert "move mirror to a separate workflow, update pipeline running rules" This reverts commit 92b4b04. --------- Co-authored-by: Matic Lubej <[email protected]>
* remove "undefined" catch-all flag from a field * mypy fixes
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 55 55
Lines 4800 4800
=======================================
Hits 4414 4414
Misses 386 386
☔ View full report in Codecov by Sentry. |
mlubej
approved these changes
Nov 13, 2023
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecator from typing_extensions has additional benefits of IDEs picking it up
I wanted to deprecate our own deprecators, but then users would get spammed with stuff that they have no control over (since it would happen on import. So I want to wait with that (or just remove them after a while)