Skip to content

Commit

Permalink
fixup! thread SENTRY_ORG and SENTRY_PROJECT from release.yml all the …
Browse files Browse the repository at this point in the history
…way to the upload symbol script
  • Loading branch information
armcknight committed Oct 4, 2023
1 parent e213165 commit 6b9fe6a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
if: steps.cache_cocoapods.outputs.cache-hit != 'true'
shell: sh
- name: Run Deploy Script
run: ./deploy_project.sh ${{ github.event.inputs.version }} ${{ secrets.SENTRY_ORG }} ${{ secrets.SENTRY_PROJ }}
run: ./deploy_project.sh ${{ github.event.inputs.version }} ${{ secrets.SENTRY_ORG }} ${{ secrets.SENTRY_PROJ }} ${{ secrets.SENTRY_AUTH_TOKEN }}
shell: sh
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
3 changes: 2 additions & 1 deletion deploy_project.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ error_exit() {

SENTRY_ORG_INPUT=${1}
SENTRY_PROJECT_INPUT=${2}
SENTRY_AUTH_TOKEN_INPUT=${3}

# Build the release bundle
echo "Building the release bundle..."
SENTRY_ORG=$SENTRY_ORG_INPUT SENTRY_PROJECT=SENTRY_PROJECT_INPUT xcodebuild -workspace EmpowerPlant.xcworkspace -scheme EmpowerPlant -configuration Release -derivedDataPath build -destination "platform=iOS Simulator,OS=latest,name=iPhone 14" -quiet clean build
SENTRY_ORG=$SENTRY_ORG_INPUT SENTRY_PROJECT=SENTRY_PROJECT_INPUT SENTRY_AUTH_TOKEN=SENTRY_AUTH_TOKEN_INPUT xcodebuild -workspace EmpowerPlant.xcworkspace -scheme EmpowerPlant -configuration Release -derivedDataPath build -destination "platform=iOS Simulator,OS=latest,name=iPhone 14" -quiet clean build
zip -r EmpowerPlant_release.zip ./build/Build/Products/Release-iphonesimulator/EmpowerPlant.app
ZIP_PATH="./EmpowerPlant_release.zip"

Expand Down
2 changes: 1 addition & 1 deletion upload-symbols.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ if which sentry-cli >/dev/null; then
fi

# get SENTRY_AUTH_TOKEN value
if [ -n "$SENTRY_AUTH_TOKEN" ]; then
if [ -n "${SENTRY_AUTH_TOKEN}" ]; then
echo "Using SENTRY_AUTH_TOKEN environment variable."
else
if [ -f ~/.sentryclirc ]; then
Expand Down

0 comments on commit 6b9fe6a

Please sign in to comment.