Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix test.yaml workflow #83

Merged
merged 18 commits into from
Apr 5, 2024
Merged

Conversation

armcknight
Copy link
Collaborator

@armcknight armcknight commented Apr 3, 2024

This gets the test.yml workflow running and successfully uploading the coverate report to codecov. I'll leave it to subsequent PRs to tweak the codecov config to your liking.

  • get the tests running in test.yml; add make test
  • remove upload-codecov-report.yml as the upload is now done in test.yml; add .codecov.yml config file as a starting point
  • use slather to process the xcodebuild coverage report
  • update macos image in GHA and the iphone destination; fix IPHONEOS_DEPLOYMENT_TARGET to use the xcode default latest version
  • to avoid uploading build symbols from the test runs, add a new build config to the Xcode project named Test

Copy link

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armcknight armcknight merged commit c882ff8 into master Apr 5, 2024
2 of 3 checks passed
@armcknight armcknight deleted the armcknight/ci/test-workflow branch April 5, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants