Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fmt): rework MoleculeStream and create MoleculeReader #164

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Nov 10, 2023

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Does all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:


@jnooree jnooree marked this pull request as draft November 10, 2023 09:46
@jnooree jnooree marked this pull request as ready for review November 10, 2023 10:01
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #164 (1507da8) into main (b06ad71) will decrease coverage by 0.11%.
The diff coverage is 96.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   95.53%   95.42%   -0.11%     
==========================================
  Files          13       13              
  Lines        2910     2928      +18     
==========================================
+ Hits         2780     2794      +14     
- Misses        130      134       +4     
Files Coverage Δ
include/nuri/fmt/base.h 100.00% <100.00%> (ø)
src/fmt/base.cpp 94.73% <100.00%> (ø)
src/fmt/mol2.cpp 91.00% <100.00%> (+0.03%) ⬆️
src/fmt/smiles.cpp 95.51% <83.33%> (-1.53%) ⬇️

@jnooree jnooree merged commit c62f6cf into main Nov 10, 2023
12 of 13 checks passed
@jnooree jnooree deleted the jnooree/issue-163 branch November 10, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework readers for multithread support
1 participant