Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python/core): fix bug on Molecule::clear* call with active mutator #290

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Apr 11, 2024

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Does all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:


When molecule is cleared with active mutator with pending erasures,
bugs might appear when mutator finalizes.
@jnooree jnooree enabled auto-merge April 11, 2024 07:39
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (12f7938) to head (207570d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   90.84%   90.86%   +0.01%     
==========================================
  Files          37       37              
  Lines        8682     8699      +17     
==========================================
+ Hits         7887     7904      +17     
  Misses        795      795              
Files Coverage Δ
python/include/nuri/python/core/core_module.h 92.16% <100.00%> (+0.38%) ⬆️
python/src/nuri/core/molecule.cpp 90.14% <100.00%> (-0.21%) ⬇️

@jnooree jnooree merged commit a69d810 into main Apr 11, 2024
16 of 17 checks passed
@jnooree jnooree deleted the jnooree/issue-289 branch April 11, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] molecule clear* methods are unsafe when a mutator is active
1 participant