Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/geometry): implement alignment algorithms #378

Merged
merged 16 commits into from
Oct 17, 2024
Merged

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Oct 17, 2024

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Does all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:


Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 91.88192% with 22 lines in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (dceee16) to head (b1b9d90).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/core/geometry.cpp 91.79% 22 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   90.21%   90.25%   +0.04%     
==========================================
  Files          39       39              
  Lines        9942    10210     +268     
==========================================
+ Hits         8969     9215     +246     
- Misses        973      995      +22     
Files with missing lines Coverage Δ
include/nuri/algo/optim.h 87.69% <ø> (ø)
include/nuri/core/geometry.h 100.00% <100.00%> (ø)
src/core/geometry.cpp 93.61% <91.79%> (-3.52%) ⬇️

@jnooree jnooree merged commit 8855a84 into main Oct 17, 2024
14 of 15 checks passed
@jnooree jnooree deleted the jnooree/issue-377 branch October 17, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement alignment algorithms
1 participant