Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update more to clang tools v19 #380

Merged
merged 5 commits into from
Oct 18, 2024
Merged

refactor: update more to clang tools v19 #380

merged 5 commits into from
Oct 18, 2024

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Oct 18, 2024

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Does all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:


This is a follow-up PR of #379.

@jnooree jnooree added the dev label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (456f4d8) to head (db5fc7c).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   90.57%   90.57%   -0.01%     
==========================================
  Files          39       39              
  Lines       10554    10553       -1     
==========================================
- Hits         9559     9558       -1     
  Misses        995      995              
Files with missing lines Coverage Δ
include/nuri/core/element.h 96.49% <100.00%> (ø)
include/nuri/core/molecule.h 85.24% <100.00%> (ø)
include/nuri/utils.h 97.82% <100.00%> (ø)
src/fmt/sdf.cpp 84.58% <100.00%> (-0.03%) ⬇️

@jnooree jnooree merged commit 0a883f9 into main Oct 18, 2024
16 of 17 checks passed
@jnooree jnooree deleted the clang-tools-19 branch October 22, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant