Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/geometry): add option to consider reflection in qcp algorithm #390

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Oct 25, 2024

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Does all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:

  • Closes #...

@jnooree jnooree added feature New feature or request api labels Oct 25, 2024
@jnooree jnooree changed the title Qcp reflection feat(core/geometry): add option to consider reflection in qcp algorithm Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.54%. Comparing base (8e7245b) to head (ab6934f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/core/geometry.cpp 87.50% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   90.53%   90.54%           
=======================================
  Files          43       43           
  Lines       11078    11085    +7     
=======================================
+ Hits        10030    10037    +7     
  Misses       1048     1048           
Files with missing lines Coverage Δ
include/nuri/core/geometry.h 100.00% <ø> (ø)
src/core/geometry.cpp 92.82% <87.50%> (+0.11%) ⬆️

@jnooree jnooree merged commit ef41c4d into main Oct 25, 2024
15 of 17 checks passed
@jnooree jnooree deleted the qcp-reflection branch October 25, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant