Indirect fontname problem #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #239 +/- ##
==========================================
+ Coverage 99.83% 99.84% +0.01%
==========================================
Files 7 7
Lines 1173 1181 +8
Branches 75 78 +3
==========================================
+ Hits 1171 1179 +8
Misses 1 1
Partials 1 1
|
sadrasabouri
commented
Jul 9, 2023
sepandhaghighi
requested changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#205
What does this implement/fix? Explain your changes.
Changed
__detailed_returnparameter added totext2artfunctionAny other comments?
By adding this new parameter to
text2artfunction, higher-level APIs can have converted font names. So warnings will be shown with the extracted font name later on.