Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export case User Interface #1788

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

gfd2020
Copy link
Collaborator

@gfd2020 gfd2020 commented Jul 27, 2023

The PR export the entire case (along with the evidences) to a folder chosen by the user.

@gfd2020 gfd2020 mentioned this pull request Jul 27, 2023
@gfd2020 gfd2020 requested a review from lfcnassif January 8, 2024 11:53
Copy link
Member

@lfcnassif lfcnassif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gfd2020, thanks for this PR. But my thoughts about this "export case" feature is to include it in the case creation UI implemented in #1341, together into that PR or after it is integrated. Users wouldn't need to open the case to just copy it to other location. I think it makes more sense to put this into the case management UI. What do you think?

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jan 19, 2024

Hi @gfd2020, thanks for this PR. But my thoughts about this "export case" feature is to include it in the case creation UI implemented in #1341, together into that PR or after it is integrated. Users wouldn't need to open the case to just copy it to other location. I think it makes more sense to put this into the case management UI. What do you think?

I think it could have both. Will the creation UI be an integral part of a processed case?

@lfcnassif
Copy link
Member

I think it could have both. Will the creation UI be an integral part of a processed case?

Initially not. Part of it, the task/module selection panel will be added to the analysis UI when #24 is implemented in the future, so users will be able to run selected modules after the initial processing.

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jan 19, 2024

I think it could have both. Will the creation UI be an integral part of a processed case?

Initially not. Part of it, the task/module selection panel will be added to the analysis UI when #24 is implemented in the future, so users will be able to run selected modules after the initial processing.

In this case, if someone only has the case processed, how will they export it to another place if they don't have Creatin UI installed?

@lfcnassif
Copy link
Member

In this case, if someone only has the case processed, how will they export it to another place if they don't have Creatin UI installed?

Simply copying by Windows Explorer? Internal absolute paths should be updated by the Analysis UI when it is opened from the copied case. Isn't that working?

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Jan 19, 2024

Simply copying by Windows Explorer? Internal absolute paths should be updated by the Analysis UI when it is opened from the copied case. Isn't that working?

I think it's working. But this PR does everything automatically and estimates the size needed for copying. I think that for a common user it is a bit complicated for them to fix the paths. Please, make a test and tell me if it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants