Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2344 gallery enhancement #2348

Merged
merged 10 commits into from
Oct 21, 2024
Merged

#2344 gallery enhancement #2348

merged 10 commits into from
Oct 21, 2024

Conversation

lfcnassif
Copy link
Member

Closes #2344.

IndexReader/IndexSearcher.doc(id) calls are heavy, moving them from AWT thread to thread pool makes gallery cell rendering parallel and non AWT blocking on spinning disks.

@wladimirleite if you could confirm it improved rendering on spinning disk, I would appreciate very much. I also copied your improvements on other classes.

@wladimirleite
Copy link
Member

Great! I didn't try moving that call.
I will test tomorrow.

@wladimirleite
Copy link
Member

wladimirleite commented Oct 21, 2024

I repeated the tests more carefully today, and the new version seems better, both using slow and fast disks. For the slow disk, the responsiveness (when scrolling the gallery with a lot of thumbnails) was improved. Thanks @lfcnassif!

I will push some minor code changes I made before, separated in small commits, so you can easily check them. Most are related to cache access. As the cache is very small (1000 items), there is no practical impact.

@lfcnassif
Copy link
Member Author

Thanks @wladimirleite! A last detail I observed yesterday, just after cherry picking your commits, the "..." loading label stopped to be shown in the center of the cells. Could you take a look? I'm in a training this whole week and I shouldn't have time soon...

@wladimirleite
Copy link
Member

A last detail I observed yesterday, just after cherry picking your commits, the "..." loading label stopped to be shown in the center of the cells. Could you take a look?

Sorry, there was a missing super.updateUI(). It should be working now.

@lfcnassif
Copy link
Member Author

Thank you @wladimirleite!

@lfcnassif lfcnassif merged commit abf8b8c into master Oct 21, 2024
2 checks passed
@lfcnassif lfcnassif deleted the #2344_gallery_enhancement branch October 21, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve gallery rendering speed
2 participants