Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dynamic #220

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Dynamic #220

wants to merge 1 commit into from

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Aug 19, 2024

  • Might be faster to use old emplace_exists, have a count, and then store the count in the occupancy - Not really a big difference

@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 79.34783% with 19 lines in your changes missing coverage. Please review.

Project coverage is 98.55%. Comparing base (2c1488a) to head (0f5dc35).

Files with missing lines Patch % Lines
include/hibf/misc/insert_iterator.hpp 0.00% 8 Missing ⚠️
src/build/insert_into_ibf.cpp 61.11% 7 Missing ⚠️
src/interleaved_bloom_filter.cpp 86.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   99.58%   98.55%   -1.04%     
==========================================
  Files          51       52       +1     
  Lines        1951     2013      +62     
  Branches        5       12       +7     
==========================================
+ Hits         1943     1984      +41     
- Misses          8       29      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seqan seqan deleted a comment from vercel bot Aug 19, 2024
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Aug 19, 2024
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/hibf/220

Copy link
Member

@smehringer smehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm why do you want to merge this already, with a user visible API, if it might still change and does not have the full feature set yet?

I would rather develop some more and start merging into seqan once we know more certainly how it will look like. E.g. maybe the dynamic HIBF will get a completely new type and config.

@eseiler eseiler marked this pull request as draft August 22, 2024 13:19
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 15, 2024
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 15, 2024
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 15, 2024
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 15, 2024
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 15, 2024
@eseiler eseiler changed the title [FEATURE] Allow empty bins in layout [WIP] Dynamic Oct 15, 2024
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 15, 2024
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 16, 2024
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants