-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Dynamic #220
base: main
Are you sure you want to change the base?
[WIP] Dynamic #220
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 99.58% 98.55% -1.04%
==========================================
Files 51 52 +1
Lines 1951 2013 +62
Branches 5 12 +7
==========================================
+ Hits 1943 1984 +41
- Misses 8 29 +21 ☔ View full report in Codecov by Sentry. |
cf5e52d
to
0456a2b
Compare
Documentation preview available at https://docs.seqan.de/preview/seqan/hibf/220 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm why do you want to merge this already, with a user visible API, if it might still change and does not have the full feature set yet?
I would rather develop some more and start merging into seqan once we know more certainly how it will look like. E.g. maybe the dynamic HIBF will get a completely new type and config.
0456a2b
to
c8757dd
Compare
e8bb777
to
8ffb0e4
Compare
8ffb0e4
to
f9f3166
Compare
f9f3166
to
225adf8
Compare
225adf8
to
2ead465
Compare
97929d9
to
0f5dc35
Compare
emplace_exists
, have a count, and then store the count in the occupancy - Not really a big difference