Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Update layout- and add build-subnamespace #58

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

smehringer
Copy link
Member

to be consistent with sketch and layout, I added a build subnamespace

@smehringer smehringer mentioned this pull request Aug 30, 2023
25 tasks
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 86.66% and project coverage change: -1.96% ⚠️

Comparison is base (debe6f5) 93.77% compared to head (0ab2aa0) 91.82%.

❗ Current head 0ab2aa0 differs from pull request most recent head 72cdc3e. Consider uploading reports for the commit 72cdc3e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   93.77%   91.82%   -1.96%     
==========================================
  Files          39       40       +1     
  Lines        1350     1345       -5     
==========================================
- Hits         1266     1235      -31     
- Misses         84      110      +26     
Files Changed Coverage Δ
include/hibf/build/bin_size_in_bits.hpp 100.00% <ø> (ø)
include/hibf/build/build_data.hpp 100.00% <ø> (ø)
include/hibf/build/update_parent_kmers.hpp 0.00% <ø> (ø)
include/hibf/build/update_user_bins.hpp 100.00% <ø> (ø)
include/hibf/layout/data_store.hpp 88.88% <ø> (ø)
src/build/compute_kmers.cpp 100.00% <ø> (ø)
src/build/construct_ibf.cpp 94.11% <ø> (+0.36%) ⬆️
src/build/insert_into_ibf.cpp 50.00% <ø> (ø)
src/hierarchical_interleaved_bloom_filter.cpp 81.60% <80.00%> (+3.70%) ⬆️
src/layout/compute_layout.cpp 100.00% <100.00%> (ø)
... and 1 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 3:25pm

@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Sep 1, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Sep 1, 2023
@eseiler eseiler merged commit 5071729 into seqan:main Sep 1, 2023
26 checks passed
@smehringer smehringer deleted the subnamespaces branch September 4, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants