Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Small correction in binning_bitvector_benchmark #76

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Sep 5, 2023

To determine the number of words, (bitvector.size() + 63u) >> 6 is more correct than bitvector.size() >> 6.

The binning_bitvector can have a size that is not a multiple of 64; currently, the IBF can be constructed with an arbitrary bin count. However, any unused bits in this case are always 0.

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 4:47pm

@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Sep 5, 2023
@eseiler eseiler merged commit bbb88f8 into seqan:main Sep 5, 2023
24 checks passed
@eseiler eseiler deleted the test/small branch September 5, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants