Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmax
shouldn't be initialised to a value other than 0, otherwise we will never set a default65472
, because the next multiple of 64 would be65536
For discussion:
size_t
?input_fn
in the config is needed such thatinput_fn
doesn't need to be provided when using designated intialisers (input_fn
would be uninitialised otherwise, default ctor is not affected). Would be a way to makeinput_fn
mandatory, but it doesn't really seem in the spirit of designated initialisers, and it would also hinder use cases such as first using desginated initialisers for construction, and settinginput_fn
afterwards (workaround would probably be.input_fn = {}
).