Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] IBF is now constructible from hibf::config. #80

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

smehringer
Copy link
Member

As discussed we will for now use one large config object where layout stuff is ignored by the ibf.

In future versions the ibf may get its own config.

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:28pm

@seqan-actions seqan-actions added the lint [INTERNAL] used for linting label Sep 7, 2023
@smehringer smehringer mentioned this pull request Sep 7, 2023
25 tasks
@seqan-actions seqan-actions removed the lint [INTERNAL] used for linting label Sep 7, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Sep 7, 2023
@seqan-actions seqan-actions added the lint [INTERNAL] used for linting label Sep 7, 2023
@seqan-actions seqan-actions removed the lint [INTERNAL] used for linting label Sep 7, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (a1f9b4f) 94.24% compared to head (4b68cc4) 94.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   94.24%   94.30%   +0.06%     
==========================================
  Files          38       39       +1     
  Lines        1337     1353      +16     
==========================================
+ Hits         1260     1276      +16     
  Misses         77       77              
Files Changed Coverage Δ
include/hibf/interleaved_bloom_filter.hpp 100.00% <ø> (ø)
src/interleaved_bloom_filter.cpp 100.00% <100.00%> (ø)
src/layout/compute_layout.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseiler eseiler merged commit ae9355d into seqan:main Sep 7, 2023
26 checks passed
@smehringer smehringer deleted the ibf_ctor branch October 16, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants