Update Google cloud regions #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloaledo
force-pushed
the
update-google-cloud-regions
branch
2 times, most recently
from
e2de474 to
a5e74dd
Compare
stefanoboriero
approved these changes
Jan 17, 2025
| "australia-southeast2": "Asia Pacific (Melbourne)", | ||
| "asia-northeast3": "Asia Pacific (Seoul)", | ||
| "me-west1": "Middle East (TelAviv)", | ||
| "me-central1": "Middle East (Doha)", |
There was a problem hiding this comment.
Seems like there's also "me-central2" now, however it requires some exotic access rules https://cloud.google.com/docs/dammam-region-access, not sure if it's worth adding it now or wait to have someone actually using such region. I'm happy to approve as is, just to let you know
.github/workflows/docker.yaml
Outdated
| @@ -1,81 +0,0 @@ | |||
| name: Docker | |||
There was a problem hiding this comment.
This file is already removed in #21 should we get that merged?
Signed-off-by: Jordi Deu-Pons <[email protected]>
Signed-off-by: Pablo <[email protected]>
jordeu
force-pushed
the
update-google-cloud-regions
branch
from
a5e74dd to
357a1a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Google Cloud regions.
I've used this helper script with some manual replacements to update the regions.