Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure CE walkthrough to help highlight platform features #334

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add Azure CE walkthrough to help highlight platform features #334

wants to merge 8 commits into from

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Dec 5, 2024 •
edited
Loading

A walkthrough from least to most complex CE setup for Azure Batch.

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 893279f
🔍 Latest deploy log https://app.netlify.com/sites/seqera-docs/deploys/677e7efef6861700085242b8
😎 Deploy Preview https://deploy-preview-334--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@justinegeffen justinegeffen added 1. Editor review Needs a language review 1. Dev/PM review Needs a review by a Dev or PM labels Dec 6, 2024
@justinegeffen
Copy link
Contributor

Thanks, @adamrtalbot, this looks awesome. I've added a few reviewers. Is there a deadline that you have in mind for this in terms of publication?

@adamrtalbot
Copy link
Contributor Author

Thanks, @adamrtalbot, this looks awesome. I've added a few reviewers. Is there a deadline that you have in mind for this in terms of publication?

No - it's just been a recurring issues so I thought a solid walkthrough was required. It's a little bit dependent on #325 for full context.

justinegeffen
justinegeffen reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@justinegeffen justinegeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started reviewing this and realized that my edits will be more effective if I edit directly. I'm submitting these anyway - @adamrtalbot, could you let me know if you're comfortable with me editing directly and if there's access to the UIs you reference in the tutorial?

platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated
---
title: Azure Batch Set Up
headline: "Azure Batch Compute Environment Tutorial"
description: "An walkthrough for using Azure Batch with Seqera Platform"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a 'how to use Azure Batch', but it's very surface level. This was more of a tutorial allowing users to run through a specific guide, so I'm not sure I like calling it "Use Azure Batch".

platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated Show resolved Hide resolved
platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated Show resolved Hide resolved
platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated Show resolved Hide resolved
platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated Show resolved Hide resolved
platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated Show resolved Hide resolved
platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated Show resolved Hide resolved
platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated Show resolved Hide resolved
platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated Show resolved Hide resolved
platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated Show resolved Hide resolved
adamrtalbot
adamrtalbot commented Dec 13, 2024
View reviewed changes
platform_versioned_docs/version-24.2/enterprise/advanced-topics/azure-batch-standup.mdx Outdated
---
title: Azure Batch Set Up
headline: "Azure Batch Compute Environment Tutorial"
description: "An walkthrough for using Azure Batch with Seqera Platform"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a 'how to use Azure Batch', but it's very surface level. This was more of a tutorial allowing users to run through a specific guide, so I'm not sure I like calling it "Use Azure Batch".

@adamrtalbot
Copy link
Contributor Author

@justinegeffen merge your fixes away, happy for you to make any changes you think are appropriate.

@adamrtalbot @justinegeffen
Apply suggestions from code review
c413f65 
Co-authored-by: Justine Geffen <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
@adamrtalbot
Copy link
Contributor Author

Note this one doesn't make much sense until #325 is merged.

llewellyn-sl
llewellyn-sl reviewed Jan 8, 2025
View reviewed changes
platform_versioned_docs/version-24.2/enterprise/advanced-topics/manual-azure-batch-setup.mdx

It is common to attach Azure Batch pools to a virtual network. This is useful to connect to other resources in the same VNet or place things behind enhanced security. Seqera Platform does not support this feature directly, so you must manually create an Azure Batch pool.

See [Create a pool with a Virtual Network in the Azure portal](https://learn.microsoft.com/en-us/azure/batch/batch-virtual-network#create-a-pool-with-a-virtual-network-in-the-azure-portal) to create an Azure Batch pool manually that is compatible with Seqera and Nextflow. Use the following settings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamrtalbot This URL was still TODO before. Let me know if this docs link I plugged in is the appropriate one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be the one in #325 because there are a lot of specific requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llewellyn-sl llewellyn-sl llewellyn-sl left review comments

@justinegeffen justinegeffen justinegeffen left review comments

@robsyme robsyme Awaiting requested review from robsyme

@christopher-hakkaart christopher-hakkaart Awaiting requested review from christopher-hakkaart

@markpanganiban markpanganiban Awaiting requested review from markpanganiban

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
1. Dev/PM review Needs a review by a Dev or PM 1. Editor review Needs a language review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamrtalbot @justinegeffen @llewellyn-sl