Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting the service account email when creating a google batch CE #426

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

JaimeSeqLabs
Copy link
Contributor

Description

Closes #316

Allow setting the service account email address as configuration field when creating a new Google Batch compute environment.

Guidelines for testing

Create a new Google Batch CE setting the service account email address:

$> ./tw compute-envs add google-batch -n GoogleBatchTest -c JaimeGoogleCredsDev --work-dir=gs://jaime-test-workdir --location=europe-west2 --service-account-email=<YOUR_SERVICE_ACCOUNT_EMAIL>

Copy link
Contributor

@tcrespog tcrespog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved conflicts. Tested and works.

@tcrespog tcrespog merged commit 98f8b61 into master Sep 11, 2024
12 checks passed
@@ -1,3 +1,3 @@
# Enable auto-env through the sdkman_auto_env config
# Add key=value pairs of SDKs to use below
java=17.0.8-graalce
java=21.0.4-graal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a CE version of the VM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems Java 21 is being used as of recently. In GitHub Actions, we are using GraalVM 21 "non-CE" too. Here, I've just updated .sdkmanrc to align them accordingly. In fact, with GraalVM 21 CE it doesn't seem to work.

image

I'll start a discussion about this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use it under the new Graalvm license

Subject to the conditions in the license, including the License for Early Adopter Versions, the GFTC is intended to permit use by any user including commercial and production use. Redistribution is permitted as long as it is not for a fee

https://www.graalvm.org/faq/

@ewels ewels deleted the 316-add-google-batch-svc-account-email branch September 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the headJobServiceAccountEmail to Google Batch Advanced Options
5 participants