Skip to content

Commit

Permalink
Use the newly stabilized div_ceil
Browse files Browse the repository at this point in the history
Sets a msrv of 1.73.0.
  • Loading branch information
kayabaNerve committed Oct 5, 2023
1 parent 4ee65ed commit 9cdca1d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 13 deletions.
2 changes: 1 addition & 1 deletion coins/bitcoin/src/wallet/send.rs
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ impl SignableTransaction {
// multiplied by DEFAULT_BYTES_PER_SIGOP (20)
// We only use 1 signature per input, and our inputs have a weight exceeding 20
// Accordingly, our inputs' weight will always be greater than the cost of the signature ops
let vsize = (weight + 3) / 4;
let vsize = weight.div_ceil(4);
// Technically, if there isn't change, this TX may still pay enough of a fee to pass the
// minimum fee. Such edge cases aren't worth programming when they go against intent, as the
// specified fee rate is too low to be valid
Expand Down
3 changes: 1 addition & 2 deletions coins/monero/src/wallet/seed/polyseed.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ fn birthday_decode(birthday: u16) -> u64 {
const SECRET_BITS: usize = 150;

const BITS_PER_BYTE: usize = 8;
// ceildiv of SECRET_BITS by BITS_PER_BYTE
const SECRET_SIZE: usize = (SECRET_BITS + BITS_PER_BYTE - 1) / BITS_PER_BYTE; // 19
const SECRET_SIZE: usize = SECRET_BITS.div_ceil(BITS_PER_BYTE); // 19
const CLEAR_BITS: usize = (SECRET_SIZE * BITS_PER_BYTE) - SECRET_BITS; // 2

// Polyseed calls this CLEAR_MASK and has a very complicated formula for this fundamental
Expand Down
2 changes: 1 addition & 1 deletion crypto/transcript/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ where

// block_size returns the block_size in bytes
// Use a ceil div in case the block size isn't evenly divisible by our word size
let words = (D::block_size() + (WORD_SIZE - 1)) / WORD_SIZE;
let words = D::block_size().div_ceil(WORD_SIZE);
for _ in 0 .. (2 * words) {
self.0.update([255; WORD_SIZE]);
}
Expand Down
10 changes: 1 addition & 9 deletions processor/src/multisigs/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -229,14 +229,6 @@ impl<D: Db, N: Network> MultisigManager<D, N> {
}

fn current_rotation_step(&self, block_number: usize) -> RotationStep {
fn ceil_div(num: usize, denom: usize) -> usize {
let res = num / denom;
if (res * denom) == num {
return res;
}
res + 1
}

let Some(new) = self.new.as_ref() else { return RotationStep::UseExisting };

// Period numbering here has no meaning other than these the time values useful here, and the
Expand All @@ -250,7 +242,7 @@ impl<D: Db, N: Network> MultisigManager<D, N> {
// N::CONFIRMATIONS + 10 minutes
let period_1_start = new.activation_block +
N::CONFIRMATIONS +
ceil_div(10 * 60, N::ESTIMATED_BLOCK_TIME_IN_SECONDS);
(10usize * 60).div_ceil(N::ESTIMATED_BLOCK_TIME_IN_SECONDS);

// N::CONFIRMATIONS
let period_2_start = period_1_start + N::CONFIRMATIONS;
Expand Down

0 comments on commit 9cdca1d

Please sign in to comment.