Improve batch handling #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayabaNerve
requested changes
Aug 3, 2023
processor/messages/src/lib.rs
Outdated
| @@ -61,6 +62,7 @@ pub mod sign { | |||
| pub struct SignId { | |||
| pub key: Vec<u8>, | |||
| pub id: [u8; 32], | |||
| pub block: Option<BlockHash>, | |||
There was a problem hiding this comment.
Why is this an Option? Due to the SignId reuse for Batch?
There was a problem hiding this comment.
Yes. It is used in SignId for batches but not in coordinator/tributary/scanner see my reply to #316 (comment) as well
kayabaNerve
force-pushed
the
limit-batch-size
branch
from
8ab595b
to
2df8bf6
Compare
Doesn't yet update tests/processor until data flow is inspected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #280 alongside some improvements