Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial dex pallet support #363

Closed
wants to merge 10 commits into from
Closed

initial dex pallet support #363

wants to merge 10 commits into from

Conversation

akildemir
Copy link
Contributor

No description provided.

kayabaNerve
kayabaNerve reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@kayabaNerve kayabaNerve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have yet to review substrate/in-instructions/pallet/src/lib.rs and substrate/client/tests/dex.rs. Overall looks as expected 👍

substrate/client/src/serai/dex.rs Outdated Show resolved Hide resolved
substrate/client/tests/common/dex.rs Outdated Show resolved Hide resolved
substrate/client/tests/common/dex.rs Outdated Show resolved Hide resolved
substrate/client/tests/common/in_instructions.rs Outdated Show resolved Hide resolved
substrate/client/tests/common/in_instructions.rs Show resolved Hide resolved
substrate/runtime/src/lib.rs Outdated Show resolved Hide resolved
substrate/runtime/src/lib.rs Show resolved Hide resolved
substrate/runtime/src/lib.rs Show resolved Hide resolved
substrate/runtime/src/lib.rs Outdated Show resolved Hide resolved
substrate/runtime/src/lib.rs Outdated
@@ -143,6 +149,16 @@ parameter_types! {
);

pub const MaxAuthorities: u32 = 100;

pub const AssetConversionPalletId: PalletId = PalletId(*b"DexPalet"); // TODO: this requires exactly 8 byte?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pallet, not palet.

@akildemir akildemir closed this Oct 25, 2023
@akildemir akildemir deleted the add-dex-pallet branch October 25, 2023 09:12
@kayabaNerve kayabaNerve mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayabaNerve kayabaNerve kayabaNerve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akildemir @kayabaNerve