add missing prevotes #590
Merged
add missing prevotes #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context, this corresponds with lines 26/32 of the Tendermint specification. It prevents falsely logging we didn't receive a proposal (when we did) and slashing proposers who get rejected over temporal behavior (as we shouldn't). |
kayabaNerve
added
bug
|
Classified bug due to how any nodes yet to receive a Provided transaction would slash nodes who proposed with such a Provided transaction. |
akildemir
added a commit
to akildemir/serai
that referenced
this pull request
Aug 16, 2024
* add missing prevotes * remove the TODO * add missing current step checks --------- Co-authored-by: akildemir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.