Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer/boolean tags for internally/adjacently tagged enums #2056

Closed
wants to merge 17 commits into from
Closed

Integer/boolean tags for internally/adjacently tagged enums #2056

wants to merge 17 commits into from

Commits on Jul 11, 2021

  1. initial work

    @AmaranthineCodices
    AmaranthineCodices committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    02d32f6 View commit details
    Browse the repository at this point in the history

  2. clean up comments

    @AmaranthineCodices
    AmaranthineCodices committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    e698800 View commit details
    Browse the repository at this point in the history

  3. fold VariantNames and Name into single generic struct

    @AmaranthineCodices
    AmaranthineCodices committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    fbdb030 View commit details
    Browse the repository at this point in the history

  4. make adjacent enums serialize

    @AmaranthineCodices
    AmaranthineCodices committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    f162636 View commit details
    Browse the repository at this point in the history

  5. add test for adjacent enum

    @AmaranthineCodices
    AmaranthineCodices committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    37b4c68 View commit details
    Browse the repository at this point in the history

  6. add ui test for non-string rename on invalid enums

    @AmaranthineCodices
    AmaranthineCodices committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    b782173 View commit details
    Browse the repository at this point in the history

  7. fix missing_true_arm cond

    @AmaranthineCodices
    AmaranthineCodices committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    5d425a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. fix pattern when we don't generate a bool fallthrough arm

    @AmaranthineCodices
    AmaranthineCodices committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    cb3c394 View commit details
    Browse the repository at this point in the history

  2. fix use of type_alias_enum_variants on old rustc

    @AmaranthineCodices
    AmaranthineCodices committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    55b9d71 View commit details
    Browse the repository at this point in the history

  3. maybe fix no_std build

    @AmaranthineCodices
    AmaranthineCodices committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    9855884 View commit details
    Browse the repository at this point in the history

  4. fix clippy lints

    @AmaranthineCodices
    AmaranthineCodices committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    9869d1c View commit details
    Browse the repository at this point in the history

  5. __value_bytes, not bytes

    @AmaranthineCodices
    AmaranthineCodices committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    dcf880d View commit details
    Browse the repository at this point in the history

  6. fix duplicate visit_u64 impl

    @AmaranthineCodices
    AmaranthineCodices committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    7821a30 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. handle collect_other_fields properly

    @AmaranthineCodices
    AmaranthineCodices committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    52f5d91 View commit details
    Browse the repository at this point in the history

  2. cut down on code duplication

    @AmaranthineCodices
    AmaranthineCodices committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    69f6848 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. add test for non-string aliases

    @AmaranthineCodices
    AmaranthineCodices committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    61404e9 View commit details
    Browse the repository at this point in the history

  2. remove &'static reference to VariantName

    @AmaranthineCodices
    AmaranthineCodices committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    47ac87c View commit details
    Browse the repository at this point in the history