fix: helm create namespace #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergelogvinov
force-pushed
the
helm-namespace
branch
2 times, most recently
from
f13ebab to
9370237
Compare
LeoShivas
reviewed
Oct 17, 2023
| @@ -1,4 +1,4 @@ | |||
| {{- if ne .Release.Namespace "kube-system" }} | |||
| {{- if and .Values.createNamespace (ne .Release.Namespace "kube-system") }} | |||
There was a problem hiding this comment.
I don't undestand the meaning of the createNamespace boolean. In my #95 issue, I've demonstrated that the creation of the namespace doesn't work.
Is the boolean aim to disable the namespace creation only ?
Also, if we don't enter in th if condition, you don't indicate int the README to add the security labels to the namespace. Are they mandatory ?
There was a problem hiding this comment.
Yeah, I was too focused on the review. You said in my issue that you just want to disable the namespace creation.
My bad. :-)
There was a problem hiding this comment.
You are correct; we need to clarify the required label if someone wants to create namespace manually.
LeoShivas
approved these changes
Oct 17, 2023
LeoShivas
approved these changes
Oct 17, 2023
Add an options that adds namespace in helm template result. Signed-off-by: Serge Logvinov <[email protected]>
sergelogvinov
force-pushed
the
helm-namespace
branch
from
9370237 to
5e78af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What? (description)
Add an options that adds namespace in helm template result.
#95
Why? (reasoning)
Acceptance
Please use the following checklist:
make lint)make unit)