Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref flake instrumentation into adapter IV/V #120

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Aug 11, 2021

This PR is built cumulatively on top of
three other PRs.

For confidence in review, only the fourth
commit is meant to be considered.

  • Refactor data to settings (specificity)
  • Refactor data structures into their own module
  • Refactor implement from_str trait for Target data
  • Refactor move flake parsing into adapter file

By moving the flake adapter into it's own module,
we make future implementations of a different
data source at least more obvious.

Since this tool has become a lib, we might seem
implementations in this field.

@blaggacao blaggacao changed the title ref flake instrumentation into adapter ref flake instrumentation into adapter IV/V Aug 11, 2021
@blaggacao blaggacao force-pushed the ref-flake-instrumentation-into-adapter branch from 519661d to aff6f1f Compare August 26, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant