Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref homologate data structures V/V #121

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

blaggacao
Copy link
Contributor

This PR is built cumulatively on top of
four other PRs.

For confidence in review, only the fifth
commit is meant to be considered.

  • Refactor data to settings (specificity)
  • Refactor data structures into thier own module
  • Refactor implement from_str trait for Target data
  • Refactor move flake parsing into adapter file
  • Refactor homologate data structures

This PR finally culminantes based on the preparatory
PRs to homologate the internal data structures.

This will allow us (and newcomers to the codebase)
to more easied reason about the nature of certain
internal state.

TODO: assimilate #116
once merged.

src/settings.rs Outdated
rename(deserialize = "sshOpts")
)]
#[merge(strategy = merge::vec::append)]
pub ssh_opts: Vec<String>, // TODO: figure out type casting
Copy link
Contributor Author

@blaggacao blaggacao Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blaggacao blaggacao changed the title ref homologate data structures ref homologate data structures V/V Aug 11, 2021
@blaggacao blaggacao force-pushed the ref-homologate-data-structures branch from c6c2f00 to 77e28b7 Compare August 26, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant