[EDNA-130] Add an optimized getter of filtered experiments #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gromakovsky
force-pushed
the
gromak/edna130-optimized-filter-experiments
branch
3 times, most recently
from
f26fa82
to
7090ab3
Compare
gromakovsky
changed the title
Problem: in order to construct dashboard selectors we use the `/experiments` endpoint to get all experiments. It sends a lot of data and works slowly, especially when we pass no filters. Solution: add another endpoints that returns only names of relevant projects, compounds and targets. It works much faster, returns less data and still makes it possible to construct selectors. In future we'll also add endpoints to query all project/compound/target names without querying all data about them.
Problem: sometimes we need to know names of all entities of certain, e. g. all projects on upload page, so that the user can select a project. Currently it can be done by calling `/projects`, but it's a bit expensive because it also gets more data than necessary. Solution: add new endpoints to get names of all entities. For projects we have 2 such getters: all projects in the system (including projects without any experiments) and only projects with experiments. All projects in the system are needed for the Upload page and all projects with experiments are needed for the Dashboard page.
gromakovsky
force-pushed
the
gromak/edna130-optimized-filter-experiments
branch
from
7090ab3
to
ea9e00b
Compare
|
Apparently this PR won't be reviewed/merged any time soon. Maybe we'll come back to it in summer. Here are a couple of things we should improve:
|
|
One more TODO: use new getters of names in this PR or make sure there is an issue about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to construct dashboard selectors we use the
/experimentsendpoint which sends a lot of data, especially if you pass no filters (which happens for example if you open dashboard from scratch and it has no filters). So we add another endpoint which returns only data about experiments necessary to construct dashboard selectors. Additionally, we add endpoints to query names of all projects, compounds, etc. because they work faster than/projects,/compounds, etc.It's ready, but I want to add more tests/improve existing ones.
Related issue(s)
Resolves https://issues.serokell.io/issue/EDNA-130
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Stylistic guide (mandatory)