[OPS-1402] Add warning about missing systemd restart policy #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvem
reviewed
Dec 20, 2023
| "acme-" | ||
| "mdmonitor" | ||
| "iodined" | ||
| "copr-cli" |
There was a problem hiding this comment.
Hmm, I think that's not an actual service and just a leftover that is relevant to serokell/vault-secrets#25 😅
rvem
reviewed
Jan 9, 2024
| @@ -0,0 +1,1167 @@ | |||
| 3proxy | |||
There was a problem hiding this comment.
Is there a way to quickly generate this list?
Problem: We want to be notified that restart setup is needed when developing/testing/deploying a new module. Solution: Add warning about missing systemd restart policy.
Sereja313
force-pushed
the
sereja/OPS-1402-restart-policy-warning
branch
from
40e6a45 to
d42f159
Compare
delete-merged-branch
bot
deleted the
sereja/OPS-1402-restart-policy-warning
branch
rvem
pushed a commit
that referenced
this pull request
Apr 30, 2024
Problem: We want to be notified that restart setup is needed when developing/testing/deploying a new module. Solution: Add warning about missing systemd restart policy.
rvem
pushed a commit
that referenced
this pull request
Sep 17, 2024
Problem: We want to be notified that restart setup is needed when developing/testing/deploying a new module. Solution: Add warning about missing systemd restart policy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We want to be notified that restart setup is needed when developing/testing/deploying a new module.
Solution: Add warning about missing systemd restart policy.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.