[Chore] Update some dependencies #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following command passes: > cabal test --constraint 'hedgehog==1.5' --constraint 'doctest==0.23.0'
haskell/actions/setup was deprecated and suggests using haskell-actions/setup.
gromakovsky
force-pushed
the
gromak/maintenance-jan25
branch
from
a010c72 to
1c100bb
Compare
int-index
approved these changes
Jan 22, 2025
src/Time/Units.hs
Outdated
| @@ -72,7 +72,9 @@ import Control.Monad.IO.Class (MonadIO, liftIO) | |||
| import Data.Char (isDigit, isLetter) | |||
| import Data.Coerce (coerce) | |||
| import Data.Data (Data) | |||
| #if ( __GLASGOW_HASKELL__ < 910 ) | |||
There was a problem hiding this comment.
This conditional is related to library changes, not language changes, so it would be more appropriate to check it with #if !(MIN_VERSION_base(4,20,0))
Problem: foldl' is exported from Prelude starting from ghc-9.10 (base 4.20), so explicitly importing it causes a warning. Solution: use CPP to import it only for base older than 4.20.
Problem: with recent ghc readme-test complains about orphan instances in README.md. Solution: these instances are intentionally defined in README, so we supress the warning.
There are some minor changes in the package, so we're bumping the patch version.
gromakovsky
force-pushed
the
gromak/maintenance-jan25
branch
from
9d44b65 to
52385db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps upper bounds on some deps and updates tooling versions in CI config.
Related issue(s)
None
✅ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)
✓ Release Checklist
o-clock.cabal.under the "Unreleased" section to a new section for this release version.
I added
@sincehaddock annotations.with a summary of all user-facing changes.
vX.Y.Z