Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package doesn't compile with GHC 9.10 #296

Closed
arybczak opened this issue Oct 8, 2024 · 1 comment · Fixed by #297
Closed

Package doesn't compile with GHC 9.10 #296

arybczak opened this issue Oct 8, 2024 · 1 comment · Fixed by #297

Comments

@arybczak
Copy link

arybczak commented Oct 8, 2024

The fix is quite simple: arybczak@c96a371

I didn't make a PR because I'll let you decide whether you want to use -Wno-dodgy-imports or use CPP to silence the warning in lower GHC versions 🙂
gromakovsky added a commit that referenced this issue Oct 15, 2024
@gromakovsky
[#296] Support ghc-9.10.1
9159aac 
Problem: there is ghc-9.10 for a while, but we don't
support it for several reasons.

Solution:
1. Ignore foldl' import from Prelude in one module if GHC version
is 9.10 or newer. This export was added to Prelude in base-4.20.
2. Add 9.10.1 to tested-with.
3. Update the CI config accordingly. 9.6 is still considered
as the main version (as it's used in the latest LTS resolver), so
we use it for 3 OS.
@gromakovsky gromakovsky mentioned this issue Oct 15, 2024
Merged
13 tasks
gromakovsky added a commit that referenced this issue Oct 16, 2024
@gromakovsky
Merge pull request #297 from serokell/gromak/support-ghc-9.10
0b4a903 
[#296] Support ghc-9.10
@gromakovsky
Copy link
Member

@arybczak thanks, I took the liberty to use CPP. Merged #297, created a new release: https://hackage.haskell.org/package/universum-1.8.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#296] Support ghc-9.10 serokell/universum
2 participants
@arybczak @gromakovsky