[#296] Support ghc-9.10 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gromakovsky
force-pushed
the
gromak/support-ghc-9.10
branch
from
65de90e to
5ba3d98
Compare
Problem: there is ghc-9.10 for a while, but we don't support it for several reasons. Solution: 1. Ignore foldl' import from Prelude in one module if GHC version is 9.10 or newer. This export was added to Prelude in base-4.20. 2. Add 9.10.1 to tested-with. 3. Update the CI config accordingly. 9.6 is still considered as the main version (as it's used in the latest LTS resolver), so we use it for 3 OS.
http://www.stephendiehl.com/posts/protolude.html is no longer accessible.
Problem: CI refuses to build universum with GHC-9.10 because of `gauge`. It turned out to be a deprecated package. Solution: as temporary measure we disable building benchmarks completely. However, we should migrate to another library later. An issue is created for it.
gromakovsky
force-pushed
the
gromak/support-ghc-9.10
branch
from
5f089ec to
06dc3f2
Compare
int-index
reviewed
Oct 15, 2024
CHANGES.md
Outdated
| ======= | ||
|
|
||
| * [#297](https://github.com/serokell/universum/pull/297) | ||
| * User-invisible change to support GHC-9.10. |
There was a problem hiding this comment.
Is "user-invisible" common terminology? I'd just say "Add support for GHC 9.10"
There was a problem hiding this comment.
I slightly dislike "Add support for GHC 9.10" because sometimes it hides user-visible changes which can matter to whoever reads this changelog. I think I'll change it to "Add support for GHC 9.10 without any user-visible changes".
P. S. You may argue that the fact that I'm changing only the latest version component already implies that there are no user-visible changes, but sometimes people don't follow PVP (intentionally or not), so it's not guaranteed.
int-index
approved these changes
Oct 15, 2024
gromakovsky
force-pushed
the
gromak/support-ghc-9.10
branch
from
06dc3f2 to
aad5e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: there is ghc-9.10 for a while, but we don't support it for several reasons.
Solution:
Related issues(s)
Resolves #296
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
I checked whether these changes impact the
.hlint.yamlrulesand updated them if needed.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Unreleasedsection if necessary) if my changes are visible to the usersand
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.
✓ Release Checklist
universum.cabal.under the "Unreleased" section to a new section for this release version.
I added
@sincehaddock annotations.with a summary of all user-facing changes.
vX.Y.Z