[#265] Make SuperComposition less brittle #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use type families and an auxiliary class to make instance resolution for `SuperComposition` more robust and predictable. Fixes serokell#265. * Make the first argument of `...` a function unconditionally, before instance selection. This can theoretically improve inference slightly, though it probably doesn't have much impact in practice.
treeowl
force-pushed
the
dfeuer/#265-coherent-super-composition
branch
from
b26edde to
0dd38bd
Compare
|
Is a migration guide required, or is the changelog entry sufficient here? If one is required, where does it go? |
|
I don't know how to write a regression test for #265; it's both compile-time and subtle. Is that required for this? |
|
Argh! I think there might be a coherence issue that needs to be resolved. Trying to get inference both ways may be fundamentally wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use type families and an auxiliary class to make instance resolution
for
SuperCompositionmore robust and predictable. Fixes SuperComposition instance resolution is brittle #265.Make the first argument of
...a function unconditionally, beforeinstance selection. This can theoretically improve inference slightly,
though it probably doesn't have much impact in practice.
Description
Related issues(s)
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
reference this issue. See also auto linking on
github.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
and
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.